Add support for build arg files in yaml format.#123
Merged
taylorsilva merged 2 commits intoconcourse:masterfrom Apr 15, 2025
Merged
Add support for build arg files in yaml format.#123taylorsilva merged 2 commits intoconcourse:masterfrom
taylorsilva merged 2 commits intoconcourse:masterfrom
Conversation
featheredtoast
force-pushed
the
add-yaml-build-args-file
branch
from
9298db4 to
82e0c08
Compare
Adds key/value yaml files as possible input for build arg file. This allows for multiline args support in files. Signed-off-by: Jeff Wong <awole20@gmail.com>
taylorsilva
force-pushed
the
add-yaml-build-args-file
branch
from
82e0c08 to
fceb601
Compare
Signed-off-by: Taylor Silva <dev@taydev.net>
taylorsilva
approved these changes
Apr 15, 2025
Member
taylorsilva
left a comment
taylorsilva
left a comment
There was a problem hiding this comment.
I updated the README with this feature. Thanks for the contribution and sorry for the long wait for a review.
Contributor
Author
|
All good, I'm glad you're able to get around to it! |
Member
|
Okay these checks are broken but I've run everything locally and it's all passing so I'm going to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds key/value yaml files as possible input for build arg file. This allows for multiline args support in from build arg files.
Since build arg file splits on newlines, it's currently not possible to do so with build arg file option: Passing yaml would allow us to set the value of build args to any string, including newlines, making this possible:
my-input/myvars.yamlsetting the build arg of
footo:closes #122